youtube-node icon indicating copy to clipboard operation
youtube-node copied to clipboard

index.d.ts typings are incorrect for callbacks

Open dnaustin opened this issue 5 years ago • 2 comments

The definition for the search method is currently:

public search(id: string, maxResults: number, params: Object, callback: (validate?: Error) => void, data?: YtResult): void;

I believe that it should be:

public search(id: string, maxResults: number, params: Object, callback: (validate?: Error, data?: YtResult) => void): void;

I also believe that the getPlaylistItemsById and related methods also have the same problem.

dnaustin avatar Mar 26 '19 11:03 dnaustin

Bumping this, same issue

Claxtastic avatar Sep 21 '20 01:09 Claxtastic

Can also confirm

Denny966 avatar Sep 26 '20 22:09 Denny966