youtube-node icon indicating copy to clipboard operation
youtube-node copied to clipboard

add PageToken to getPlayListsItemsById

Open piercus opened this issue 8 years ago • 7 comments

piercus avatar Mar 15 '16 11:03 piercus

In Review. Please wait.

paulomcnally avatar Mar 16 '16 09:03 paulomcnally

I could use the pageToken functionality in this PR as well.

TheConnMan avatar Jan 04 '17 01:01 TheConnMan

Hello @paulomcnally, can i do something to help on this pr review ?

piercus avatar Jan 18 '17 09:01 piercus

Any progress on the review ?

I'm really glad to benefit from this open-source project but this PR has been opened 685 days ago and i'm wondering if this project is still maintained.

Thank you for your feedbacks

piercus avatar Jan 29 '18 07:01 piercus

@piercus: Seems master has been updated since this PR was made. This branch now has conflicts that need to be resolved.

Actually, the "add maxResults" has already been done in the current version of this repo. The version of the file lib/youtube.js in master uses this function signature getPlayListsItemsById = function(id, maxResults, callback) https://github.com/nodenica/youtube-node/blob/master/lib/youtube.js

So you should rename this PR to "add PageToken to getPlayListsItemsById" because that's the only new argument.

//Just another guy who uses this library

niklasHagner avatar Jan 29 '18 19:01 niklasHagner

@niklasHagner thank you for your comments.

  • Merged
  • added an example with pageToken
  • changed hardcoded 8 to config.max

Tell me what you think

Travis is failing but i think this is due to misconfiguration of the travis build which should have process.env.YOUTUBE_API defined with environment variables

piercus avatar Jan 30 '18 09:01 piercus

Looks good :thumbsup:

niklasHagner avatar Feb 04 '18 13:02 niklasHagner