noaa icon indicating copy to clipboard operation
noaa copied to clipboard

switch to namedtuple for coordinates parameters (**BREAKS API**)

Open toppk opened this issue 5 years ago • 2 comments

this change makes the api a little bit more consistent. it creates a object (a namedtuple) for coodinates, and replaces all uses of lat/long inside noaa_sdk.noaa with this type.

in addition to api breakage, there was a coordinate truncation done in get_observations() that I moved to points() (and implemented as string formatting).

happy to further explain or correct as needed.

toppk avatar Jul 03 '19 21:07 toppk

@toppk thanks. I'm thinking may be you can overload the methods, making them able to accept both coordinate type and tuple.

paulokuong avatar Jul 27 '19 12:07 paulokuong

which methods? all of them?

toppk avatar Aug 23 '19 20:08 toppk