noble-curves icon indicating copy to clipboard operation
noble-curves copied to clipboard

EdDSA: add validate-after-sign

Open paulmillr opened this issue 1 year ago • 3 comments

https://github.com/openpgpjs/noble-curves/commit/559e53c4293d9f858e2fa74502c1c37fba6a90b5

@larabr a pr would be highly appreciated!

paulmillr avatar Dec 31 '23 04:12 paulmillr

Sure, I can open it. FWIW we are still gathering some stats to understand if this sort of bitflips do happen in the wild. Let me know if you want to add this feature regardless 👌

larabr avatar Jan 04 '24 08:01 larabr

It's only few lines of code - seems useful "just in case".

paulmillr avatar Jan 04 '24 09:01 paulmillr

(Sorry but I haven't gotten around to opening the PR yet).

FYI there is now an RFC draft about non-deterministic EdDSA signature to tackle the underlying issue: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-det-sigs-with-noise-03 . I think implementing that variant is probs a better solution for people who do not care about the deterministic result 🙂

larabr avatar Mar 22 '24 16:03 larabr