Paul Melnikow

Results 167 comments of Paul Melnikow

This issue is still valid and has some tests in progress: #1065. I'm going to pin it for now.

I'm not necessarily convinced we should make this more lenient, though we should definitely throw an error instead of no-opping when the input is invalid.

It would be good to find a way to keep the state intact without modifying the request (especially since we're starting to adopt `got` for testing: #1294).

I'm running into this issue trying to rewrite a test for #1404. ```js test('records and replays nocks correctly', {only: true}, async function(t) { const exampleBody = 'example' const server =...

Interesting failure. While `url.parse('http://[2607:f0d0:1002:51::4]:8080').hostname` drops the brackets and produces `'2607:f0d0:1002:51::4'`, `new URL('http://[2607:f0d0:1002:51::4]:8080').hostname` keeps the brackets and produces `'[2607:f0d0:1002:51::4]'`. It looks like Nock is concatenating the port onto the unbracketed IPv6...

The example you provided isn't valid JavaScript: ```js {"THIS IS THE REPLY BODY"} ```

This use case seems to work fine. I added a test case in #2219.

Sorry, didn't mean to upset you. I was trying to determine if this is a bug in Nock, or if there was something strange about your use case that was...

Happy to reopen this if an API is made available!