Paul Irwin

Results 40 comments of Paul Irwin

@MpoMp Sounds like a good idea. Based on my interpretation of the Apache license, I assume we would just need to make sure to include the Apache license header and...

Disregard my deleted comment. What I meant was, isn't this the same as src/main/java/info/debatty/java/stringsimilarity/NGram.java?

There is no native code in this library, and therefore if there are CPU architecture differences at runtime that would be a JVM bug. Doesn't seem like there needs to...

... and I just noticed after posting this that 0.583333 ~= (1 - 0.416666). So this is an issue of difference vs similarity I guess. But I suppose we still...

I think this might be a case of the README being incorrect, as it looks like the logic was changed as a result of #22

I am unsure if this is the same issue or a separate one, but we noticed the same problem with `IDataProtectionProvider` instead of `ILogger`, but it only started happening after...

@SingThatSong Thanks for the analysis! I do like limiting the scope of this change just to where it is the most impactful. I'd love to see a PR with your...

This is completed for Ratcliff-Obsershelp via #33, please add new issues with benchmarks for other types if needed. Thanks!

Closing this issue until such a time as a fix is implemented upstream.

I have begun reviewing the core T-Z tests. So far I've made it through Automaton and it was all good apart from some very minor formatting that I'll PR once...