pwmetrics icon indicating copy to clipboard operation
pwmetrics copied to clipboard

Feature request: Report metrics to Graphite/ Cloudwatch/ etc

Open vinhlh opened this issue 7 years ago • 6 comments

Similar to uploading Lighthouse traces, we could report metrics to Monitoring services like Graphite, Cloudwatch, etc.

What do you guys think?

This looks similar to submit option, we could support multiple providers: 'gsheet', 'graphite', etc, right?

vinhlh avatar Feb 25 '18 04:02 vinhlh

We were thinking about multiple providers here - https://github.com/paulirish/pwmetrics/blob/master/lib/sheets/index.ts#L13-L15.

I think others would not mind having a few more providers :)

@vinhlh are you interested working on it?

denar90 avatar Feb 25 '18 20:02 denar90

Sure, let me give a try

vinhlh avatar Feb 26 '18 03:02 vinhlh

@vinhlh hi, did you have the ability to prototype the solution?

denar90 avatar Sep 08 '18 19:09 denar90

Hey, sorry, I was so busy, will give a try soon

vinhlh avatar Sep 10 '18 01:09 vinhlh

Nice 👍 Will be really good to have other options for submitting results :)

denar90 avatar Sep 10 '18 06:09 denar90

While it's a good idea, it couples pwmetrics with external services. Does not sound good, does it?

Mainly, I refer to feature creep and coupling.

For example, pwmetrics can be used with AppInsights as a buffer for data. Wrapped a docker container, a custom entrypoint with bash/powershell which runs pwmetrics passing command arguments, and then invokes a tiny script to post-process data and push to AppInsights. Other way around - two containers; one runs pwmetrics, second grabs the output and pushed to data storage. It's 50-lines powershell script.

Similar approach can be used for other services, AWS and others. adapters as smaller, independent scripts or containers.

Now, let's think about other tooling, Lighthouse, and many others. Most of them produce machine-readable data; json, csv or xml. Should we ask every single tool to support AWS CloudWatch, Azure, Graphite and many other data storage? - not sure.

Again, only 2cents. Intention is great, and it is totally up to the team to consider this implementation.

avishnyakov avatar Apr 08 '19 01:04 avishnyakov