CollectionViewChallenge icon indicating copy to clipboard operation
CollectionViewChallenge copied to clipboard

Created a view using the new CollectionView

Open lachlanwgordon opened this issue 5 years ago • 2 comments

Created a view using the new CollectionView

I've also implemented the same view using a ListView within this app to make it easier to do a side by side comparison. Screenshots:

Simulator Screen Shot - iPhone X - 2019-04-02 at 03 01 48 Full collection view on iPhone X.

Simulator Screen Shot - iPhone X - 2019-04-02 at 03 02 02 Full ListView on iPhoneX

Simulator Screen Shot - iPhone X - 2019-04-02 at 03 01 41 Empty Collection View on iPhone X.

Simulator Screen Shot - iPhone X - 2019-04-02 at 03 01 54 Empty view done the hard way with ListView on iPhone X.

Screenshot_1554134379 CollectionView on Nexus 6p

Screenshot_1554134339 ListView on Nexus 6p

Experience/General Feedback: Thanks for setting up this challenge. It was good fun and as a bonus a good way to practice pull requests, forking etc. as I'm quite new to contributing to open source but keen to get more involved.

Collection view is great, I especially like the empty view. This sample doesn't use many of the new features but I'm really keen on the multi column functionality for future apps.

I like that the collection view only scrolls if it has enough items to overflow the screen.

It's interesting that on iOS ListView new items slide in from behind where as they fade in on the CollectionView, on Android they both just appear. I doubt anyone would notice unless they were doing side by side comparisons.

Performance Feedback: On Android the scrolling is much faster and smoother on CollectionView when working with a large number of items.
On iOS the scrolling difference is minimal although the ListView looks to be a little smoother

On Android when adding an item at the bottom of the list there is a little shudder in the first item in the text that is different, as if the item is first rendered in the top spot and then appears at the bottom.

When I navigate to my ListView page and then back to the collection view page, I get an object disposed exception when I try to Add or Remove an item from the collection(Android only).

Performance testing done on iOS performance testing on physical iPhone 7, Android on Emulator.

Missing or Desired Things:

  • Pull to refresh(Not needed in this app but in most of my lists)
  • FooterView(I like to use these if I'm using floating action buttons)
  • ContextActions(Not needed for this app but sometimes I like them)
  • Scrolled and Scrolling events

lachlanwgordon avatar Apr 01 '19 16:04 lachlanwgordon

Thank you for the feedback! It'd be great to see some comparisons if you get the time. Pull-to-refresh is planned (via RefreshView) but not yet implemented. Similarly, the other two are planned as well via the FooterTemplate and ContextMenu mentioned in the CollectionView spec on the XF repo. I'll try and see if I get some more public visibility on what is and isn't implemented just yet.

pauldipietro avatar Apr 01 '19 19:04 pauldipietro

Hi Paul, Sorry, I'd never used the draft button before, I thought I was just saving a draft for myself to edit later. I've added screen shots and finished writing my comments.

Thanks for the great work on CollectionView so far and keeping us updated.

lachlanwgordon avatar Apr 01 '19 22:04 lachlanwgordon