Paul Smith comments

Results 133 comments of


                                            Paul Smith

Upserting using insert on conflict

I like the idea of renaming it and adding a new upsert. It's been long enough that I don't quite remember the complexities of adding upsert, but it would be...

Add support for JSON::Any columns

This is a fantastic idea. I also agree that at first it can be added w/o any special methods for querying, but eventually I'd *love* to be able to do...

Add support for Array columns.

I love this idea, but I'd like to add better support in LuckyRecord before adding it to migrator. I think for now doing it with `execute` is ok.

Make id an Int64 using bigserial

Good catch! I think for now it would be best to change it to Int32 so it can be released without having to make changes to migratory and LuckyRecord

Add support for multi-column indexes using `add_index`

I love this idea! 👍 ```crystal create_index :users, [:name, :email] ```

Split timestamp in filename so it is more approachable

I think you’re right that I added too many. Maybe just around the year month and day would work too! > On Jun 13, 2018, at 6:18 AM, Mikias Abera...

Split timestamp in filename so it is more approachable

Yeah, I think that is a perfect balance!

Consider adding method for easily creating counter caches

I would love some help with this :D And that's exactly the type of thing I'd like to see in Migrator. I think this could be done purely in Migrator...

Allow running something in a block when adding a required field to an existing table

@mikeeus Would you be interested in trying this one?

Allow running something in a block when adding a required field to an existing table

@mikeeus I'd love to give some pointers. I think the block should only be accepted when adding a required (non `?` column) when *altering* a table. For everything else, it...