build-tracker icon indicating copy to clipboard operation
build-tracker copied to clipboard

Upgrade `pg` to v8 to avoid issue with Node 14

Open OliverJAsh opened this issue 3 years ago • 3 comments

Problem

When using Postgres + Node 14, queries never resolve.

Steps to Reproduce

  1. Use Postgres + Node 14
  2. Request /api/builds/1

Expected Result

A response

Actual Result

Request hangs forever

I believe this is because of https://github.com/brianc/node-postgres/issues/2180. I suggest upgrading this dependency to v8.0.3 or above.

OliverJAsh avatar Mar 15 '21 14:03 OliverJAsh

It does solve it. @paularmstrong I can send a PR for that :)

montogeek avatar Jun 30 '21 17:06 montogeek

@paularmstrong I can send a PR for that :)

@montogeek that'd be useful to me, at least. :) i just ran into this

paulirish avatar Aug 16 '21 23:08 paulirish

btw this change will also need this.. at least to work on heroku. https://help.heroku.com/MDM23G46/why-am-i-getting-an-error-when-i-upgrade-to-pg-8

paulirish avatar Aug 17 '21 00:08 paulirish