Paul-Christian Bürkner comments

Results 738 comments of


                                            Paul-Christian Bürkner

Don't drop weights when subsetting variables?

One challenge towards this will be that we cannot just use `NextMethod` for `[]` in some cases. For example, in the corresponding .draws_matrix method I see: ```R `[.draws_matrix`

New draws_tensor format?

you are right. It is not a draws_ object but like rvar conceptually, and indeed what we do have in `draws_of()`. If you add this new format, I agree it...

New draws_tensor format?

I fully agree with your thoughts. thank you for looking into this! Matthew Kay ***@***.***> schrieb am Sa., 6. Apr. 2024, 23:49: > Hmm, I would probably wait on this...

modify summarise_draws internals not to coerce values to same type

How much increase exactly? 1% would barely matter I think

modify summarise_draws internals not to coerce values to same type

Speed is okay. Still, is this already the best way to implement the flattening?

[FR] Allow as_draws_dt for data.table

I would not be opposed to it. After all, one core principle of posterior is that we allow and support different formats because that represents the reality of its users...

[FR] Allow as_draws_dt for data.table

In other words, we would just need another draws format to make this work? That would be okay for me :-)

Weighted diagnostics

Thank you! @avehtari would you have time to review this PR?

New helper function repair_variable_names

I like "repair". Having the dots instead of [] is kind of a thing we don't really want. So we are repairing them to look reasonable again. But I also...

New helper function repair_variable_names

I agree with Jonah and Aki.