projpred: Pass `fit_elapsed_time` to `init_refmodel`

Open paul-buerkner opened this issue 5 years ago • 5 comments

As discussed in #1136

Apr 13 '21 12:04 paul-buerkner

Just a note that brms:::elapsed_time now also works with cmdstanr and defaults to NULL if no information is provided (not NA). I think NULL would also be a better default for that information in projpred.

Apr 19 '21 11:04 paul-buerkner

@fweber144 Do you know if this PR is still relevant for something that will be implemented in projpred in the future?

Apr 08 '22 13:04 paul-buerkner

Yes, for projpred's workflow branch.

Apr 08 '22 18:04 fweber144

@fweber144 Any updates on this?

Jan 28 '24 19:01 paul-buerkner

I don't think the workflow branch will be merged into master (because workflow is quite outdated now), but that doesn't mean that some of its features couldn't be re-implemented in master. Especially the timings (for which this PR is relevant) might be something that @avehtari is interested in, right?

Jan 31 '24 20:01 fweber144

I will close this PR for the time being. It's such a minor change we can do it directly on main whenever this feature makes it into projpred.

Mar 11 '24 15:03 paul-buerkner