react-intl-tel-input icon indicating copy to clipboard operation
react-intl-tel-input copied to clipboard

Fixed issue 260

Open superhit0 opened this issue 5 years ago • 7 comments

@patw0929 @nutboltu

  • Added new proptype formatFull

will be adding tests too...

putting DNM for now.

Please have a look at the logic

superhit0 avatar Jan 09 '19 01:01 superhit0

Coverage Status

Coverage increased (+0.03%) to 94.058% when pulling 90c212fa5b00034dfe97d781450d4a587730bc00 on superhit0:issue-260 into 6c8ce61a1b0239aaf9fa9bf24320eff59111f108 on patw0929:master.

coveralls avatar Jan 09 '19 01:01 coveralls

Thanks for the PR!

Is this prop using for displaying the value as formatted number with country code? Even if I use nationalMode (true is default), right?


Wait a minute, I found there is an issue with this code:

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />

And please help to update index.html for this new prop. :)

patw0929 avatar Jan 09 '19 07:01 patw0929

cool thanks for pointing it out, will have a look.

superhit0 avatar Jan 09 '19 07:01 superhit0

@patw0929

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />

I dont see format prop here, why formattting is happening?

superhit0 avatar Jan 13 '19 13:01 superhit0

Thanks for the PR!

Is this prop using for displaying the value as formatted number with country code? Even if I use nationalMode (true is default), right?

Wait a minute, I found there is an issue with this code:

        <IntlTelInput
          onPhoneNumberChange={this.changePhone3}
          onPhoneNumberBlur={this.blurHandler3}
          onSelectFlag={this.selectFlagHandler3}
          defaultCountry="auto"
          value={this.state.phoneNumber3}
          geoIpLookup={lookup}
          css={['intl-tel-input', 'form-control']}
        />

And please help to update index.html for this new prop. :)

Hi guys did found out how to resolve this issue ? i am still facing the this issue of currsor moving at wrong place @superhit0 @patw0929 ?

m-nathani avatar Jan 29 '20 02:01 m-nathani

@m-nathani Sorry I am in immense workload. Do you mind if I take a look in the weekend. By this time, can you please fix the merge conflict?

nutboltu avatar Jan 29 '20 04:01 nutboltu

@m-nathani Sorry I am in immense workload. Do you mind if I take a look in the weekend. By this time, can you please fix the merge conflict?

dont have the write access, but looking forward for the fix.. currently stuck on it

m-nathani avatar Jan 29 '20 05:01 m-nathani