milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Milvus Datatypes constant has wrong elements

Open aothelal opened this issue 2 years ago • 2 comments

Version: 0.9.1

The source code has this as the elements:

  {
    "boolean" => 1,
    "int8" => 2,
    "int16" => 3,
    "int32" => 4,
    "int64" => 5,
    "float" => 10,
    "double" => 11,
    "string" => 20,
    "varchar" => 21,
    "binary_vector" => 100,
    "float_vector" => 101
  }

But these are the values within a Pry session:

{"boolean"=>1,
 "int8"=>2,
 "int16"=>3,
 "int32"=>4,
 "int64"=>5,
 "float"=>10,
 "double"=>11,
 "string"=>20,
 "varchar"=>21,
 "binary_vector"=>101,
 "float_vector"=>102}

I think the Gem just needs to be updated on RubyGems as I found the issue inside the source code after a gem unpack, for now I used the integer values instead of the identifiers.

aothelal avatar Dec 03 '23 20:12 aothelal

@aothelal Would you be open to updating the gem?

andreibondarev avatar Dec 08 '23 14:12 andreibondarev

I encountered same issue. So is 101 a binary?

mensfeld avatar Feb 06 '24 12:02 mensfeld

All of the constants should be up to date now: https://github.com/patterns-ai-core/milvus/blob/main/lib/milvus/constants.rb

andreibondarev avatar Jul 01 '24 16:07 andreibondarev