patternfly
Bug - NumberInput - isDisabled toggle animation out of sync
Describe the problem
When toggling the isDisabled state of NumberInput the buttons and input change background color at different times.
Might be related to InputGroup in general, but only checked NumberInput.
How do you reproduce the problem?
Toggle the isDisabled here and see how the
https://codesandbox.io/p/sandbox/great-worker-dfw5fv
Expected behavior The disable animation are sync between buttons and input
Is this issue blocking you? N/A
Gonna transfer this over to our Core repo as it looks to be a CSS related issue. TLDR is the Button components have transition properties being applied that includes its background-color, but the FormControl doesn't have any such properties. So the FormControl background is changing basically in an instant, but the Button's are transitioning to the new background color. Can notice it more in the following screen recording where I have the animations playing at 10% normal speed:
https://github.com/user-attachments/assets/af1a16be-cdf9-4021-8e9f-3babbee8ad29
vs a really quick fix applying the same transition properties on FormControl as are in Button (only on the background-color):
https://github.com/user-attachments/assets/410dfdb8-06c3-4ceb-89cb-1f96896b32f6
cc @andrew-ronaldson @lboehling @kaylachumley spoke briefly with @mcoker about this, curious whether you have a strong opinion about whether the disabled styling should transition or be more of an immediate change in style.
This issue has been automatically marked as stale because it has not had activity in the last 60 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had activity in the last 60 days.
cc @andrew-ronaldson @lboehling @kaylachumley spoke briefly with @mcoker about this, curious whether you have a strong opinion about whether the disabled styling should transition or be more of an immediate change in style.
To me this seems like if we can't get it to work with transitions then disabling it would be better as the current style is very noticeable
This issue has been automatically marked as stale because it has not had activity in the last 60 days.