patternfly icon indicating copy to clipboard operation
patternfly copied to clipboard

Global - update mixins to use tokens

Open srambach opened this issue 1 year ago • 3 comments

In particular, the spacers used in mixins need to be updated to use tokens.

https://github.com/patternfly/patternfly/blob/main/src/patternfly/base/_variables.scss https://github.com/patternfly/patternfly/blob/main/src/patternfly/sass-utilities/scss-variables.scss

Question: do we still use these sass variables, or do we migrate away from maintaining these global variables in favor of the token variables?

srambach avatar Nov 30 '23 19:11 srambach

I'm definitely in favor of removing SCSS vars and just using CSS where we can, and even CSS functions in place of SCSS where possible (like math). A good example of SCSS vars we probably need are for breakpoints since you can't use a custom property in a media query currently.

mcoker avatar Nov 30 '23 20:11 mcoker

Remove as many scss variables as possible 👍

mattnolting avatar Dec 13 '23 02:12 mattnolting

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

stale[bot] avatar Feb 13 '24 04:02 stale[bot]