patternfly-react
patternfly-react copied to clipboard
Bug - Docs - Card docs mentions isSelectableRaised is preferred
Docs mention that isSelectableRaised is preferred over isSelectable, but in reality isSelectableRaised is deprecated?
https://www.patternfly.org/components/card#selectable-cards-deprecated
oh , may be a grammatical misunderstanding (comma)
This example uses the isSelectable property instead of isSelectableRaised, which is the current recommendation for implementation.
@edonehoo What do you think about the wording her and the confusion it may cause. DO you think it should be updated?
@tlabaj I'm actually also confused reading it, even though I wrote it hah. It looks like this content was written for PF 4, where the "current" selectable example used isSelectableRaised - https://v4-archive.patternfly.org/v4/components/card#selectable-cards. Is the PF 5 "deprecated" example incorrect since it doesn't match the PF 4 implementation? https://www.patternfly.org/components/card#selectable-cards-deprecated
I may be wrong here
If I am wrong, though, it seems like there's no use of isSelectableRaised in the examples on the PF 5 site -- so I do think the description needs to be updated for clarity, which I can do
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity.