patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug - Docs - Card docs mentions isSelectableRaised is preferred

Open jschuler opened this issue 1 year ago • 6 comments
trafficstars

Docs mention that isSelectableRaised is preferred over isSelectable, but in reality isSelectableRaised is deprecated?

https://www.patternfly.org/components/card#selectable-cards-deprecated

jschuler avatar Dec 08 '23 15:12 jschuler

oh , may be a grammatical misunderstanding (comma) This example uses the isSelectable property instead of isSelectableRaised, which is the current recommendation for implementation.

jschuler avatar Dec 08 '23 16:12 jschuler

@edonehoo What do you think about the wording her and the confusion it may cause. DO you think it should be updated?

tlabaj avatar Dec 13 '23 20:12 tlabaj

@tlabaj I'm actually also confused reading it, even though I wrote it hah. It looks like this content was written for PF 4, where the "current" selectable example used isSelectableRaised - https://v4-archive.patternfly.org/v4/components/card#selectable-cards. Is the PF 5 "deprecated" example incorrect since it doesn't match the PF 4 implementation? https://www.patternfly.org/components/card#selectable-cards-deprecated

I may be wrong here

edonehoo avatar Dec 13 '23 20:12 edonehoo

If I am wrong, though, it seems like there's no use of isSelectableRaised in the examples on the PF 5 site -- so I do think the description needs to be updated for clarity, which I can do

edonehoo avatar Dec 13 '23 20:12 edonehoo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jun 10 '24 11:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity.

github-actions[bot] avatar Aug 11 '24 11:08 github-actions[bot]