patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

cleanup - DataListAction - id, aria-label and aria-labelledby are not currently in use but are required

Open kmcfaul opened this issue 1 year ago • 2 comments

id can probably remain (and if so should be made non-required) but aria-label and aria-labelledby should be removed because they don't usually exist on a div without a role. These props were a holdover from when we were using a Button internally opposed to children.

kmcfaul avatar Nov 15 '23 14:11 kmcfaul

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 30 '24 03:01 stale[bot]

but aria-label and aria-labelledby should be removed because they don't usually exist on a div without a role

In addition, if they remain only one of them should be required, right?

dgdavid avatar Aug 10 '24 16:08 dgdavid