patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Menu - update drilldown inline filter example markup

Open thatblindgeye opened this issue 2 years ago • 7 comments

Describe the enhancement or change Currently the Menu with drilldown and inline filter example is rendering the search filter (drilled into level 2) as a div inside a ul element, causing an axe error to be flagged (since only li element should be direct children). Either the search input should be moved outside of the menu list or should be rendered within an li as well.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

thatblindgeye avatar Oct 27 '23 19:10 thatblindgeye

should be rendered within an li as well.

If we want to keep it in the list like that, one option could be to create a generic li that does not have any sort of hover or other treatment and could be used for putting a non-interactive type of thing in. Then the <MenuSearch> (or whatever) could be placed inside of it.

mcoker avatar Nov 07 '23 20:11 mcoker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jan 27 '25 11:01 github-actions[bot]

Let's try updating the wrapper for the filter to an li and see if that resolves it short term. We can maybe re-evaluate this implementation on a deeper level in the future.

thatblindgeye avatar Feb 20 '25 16:02 thatblindgeye

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 24 '25 11:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 03 '25 11:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 09 '25 11:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 13 '25 11:11 github-actions[bot]