patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

fix(Menu): fixed height issue with drilldown examples

Open thatblindgeye opened this issue 2 years ago • 2 comments

What: Closes #8030

Additional issues:

thatblindgeye avatar Sep 21 '22 19:09 thatblindgeye

Preview: https://patternfly-react-pr-8033.surge.sh

A11y report: https://patternfly-react-pr-8033-a11y.surge.sh

patternfly-build avatar Sep 21 '22 19:09 patternfly-build

@jenny-s51 Do you have a screenshot/video showing that behavior? I'm not sure if I'm seeing that when I drill all the way out. When comparing the "With drilldown" and "With drilldown - initial drill in state" examples, it looks like both have the same height in that top level menu after drilling all the way out.

thatblindgeye avatar Sep 23 '22 16:09 thatblindgeye

Hmm @thatblindgeye yes it does seem to work as expected in Firefox... occasionally I see anomalies in my Chrome browser that other people can't seem to replicate on the PF docs, so that may likely be the case here!

I've attached a video for reference; here's what I see in Chrome:

https://user-images.githubusercontent.com/32821331/192832304-042b4e3b-0242-4d57-8727-a1455160e1c3.mov

jenny-s51 avatar Sep 28 '22 16:09 jenny-s51

@jenny-s51 Ah interesting 🤔 This is the behavior I see using Chrome:

https://user-images.githubusercontent.com/70952936/192839038-b4a45695-c8dd-4138-ad9d-f92f5f3f0d7b.mov

thatblindgeye avatar Sep 28 '22 16:09 thatblindgeye

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Oct 10 '22 15:10 patternfly-build