patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

chore(Page): use DashboardWrapper in React demos

Open tompsota opened this issue 2 years ago • 2 comments

What: Closes #7526

I think that this PR could close also #7710 - all demos now use DashboardWrapper and number of cards was increased so it is easier to see the sticky behavior.

tompsota avatar Sep 02 '22 11:09 tompsota

Preview: https://patternfly-react-pr-7927.surge.sh

A11y report: https://patternfly-react-pr-7927-a11y.surge.sh

patternfly-build avatar Sep 02 '22 12:09 patternfly-build

So this is a little confusing, i'll admit - but I think the issue here is actually asking to make sure that the page demos match the Dashboard wrapper - not use the dashboard wrapper. That's because we want consumers to be able to use the example code to build their own page, and they cannot see the code in the dashboard wrapper.

To avoid obfuscating the solution, we need to just update the existing demos so that they match the dashboard wrapper without importing the wrapper. You could even copy/paste a lot of the code from the dashboard wrapper to make it easier.

Yeah I refactored the demos too much probably 😆 should be better now

tompsota avatar Sep 09 '22 15:09 tompsota

This looks great. I don't think any of my comments are blockers, they all look like pre-existing issues. Though they be great to fix! And most of the comments apply to all of these demos, and probably the DashboardWrapper, too. I can open new issues if you'd like, just lemme know.

@mcoker I updated the demo based on your comments. I also agree that this should be fixed in other demos and in DashboardWrapper. @nicolethoen what do you think about creating a separate issue for that??

tompsota avatar Sep 30 '22 10:09 tompsota

I also agree that this should be fixed in other demos and in DashboardWrapper. @nicolethoen what do you think about creating a separate issue for that??

I agree - go for it!

nicolethoen avatar Sep 30 '22 13:09 nicolethoen

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Sep 30 '22 20:09 patternfly-build