patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

feat(Timestamp): create component

Open thatblindgeye opened this issue 3 years ago • 1 comments
trafficstars

What: Closes #7729

Timestamp preview build

Still to-do:

  • [ ] Add classes (currently commented out the line that imports Timestamp styles)
  • [ ] Add tests
  • [ ] Possibly refactor some examples to utilize checkbox/select modifiers (i.e. the "Basic formats" example could use a single timestamp, and just have checkboxes/select menus for users to tinker with different prop values)

Additional issues:

thatblindgeye avatar Aug 10 '22 15:08 thatblindgeye

Preview: https://patternfly-react-pr-7815.surge.sh

A11y report: https://patternfly-react-pr-7815-a11y.surge.sh

patternfly-build avatar Aug 10 '22 16:08 patternfly-build

Looks awesome to me! 2 things:

  • Looks like we're missing the __text class on the time element. I'm assuming because that isn't showing up in react-styles since the class doesn't have any styles from core? In those instances, I believe what we do is hardcode the class so that it's there and we can reference it if we need without introducing a new class, but maybe one of the react devs can verify if that's still the case. I missed this comment earlier. Yeas @mcoker is correct and it looks like you already made the update.

tlabaj avatar Aug 19 '22 15:08 tlabaj

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Aug 22 '22 15:08 patternfly-build