patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

feat(WizardComposable): Created composable spinoff of wizard w/ enhancements

Open jpuzz0 opened this issue 3 years ago • 2 comments

What: Closes #7663 Depends on:

  • #7824
  • https://github.com/patternfly/patternfly-org/pull/3126

Note:

  • Unit tests for ancillary wizard components will be included in a follow-up PR.
  • 3 starting Examples have been made under a new tab called React composable in the /wizard/components doc, and the older wizard examples still reside in a React legacy tab (mimicking the composable table doc approach).

jpuzz0 avatar Jul 15 '22 20:07 jpuzz0

Preview: https://patternfly-react-pr-7703.surge.sh

A11y report: https://patternfly-react-pr-7703-a11y.surge.sh

patternfly-build avatar Jul 15 '22 20:07 patternfly-build

Weird observation, half of the components in the side nav are missing?

Also, i think this is really great! @thatblindgeye has just done some work on improving documentation for composable components included in this PR. It think it'd be good to include the prop table descriptions like he did for the File upload - multiple documentations, as well as the composable structure section.

@nicolethoen Good catch on the left nav. I think that should be fixed now. Also added descriptions to the interfaces for those Composable prop tables & added a "Structure" section as well.

jpuzz0 avatar Jul 21 '22 15:07 jpuzz0

@mcarrano @mmenestr This PR add the new composable wizard with the naming and documentation standards we had proposed. Please take a look at the React next tab and let us know if you have any concerns with naming. This is a beta components so will be continuing to work on documentation of use cases that were supported by the current wizard.

cc @jeffpuzzo

tlabaj avatar Aug 19 '22 17:08 tlabaj

I think the examples look good @tlabaj @jeffpuzzo with the assumption that we can continue to add to this.

So is "React next" the labeling we want to apply to these types of new and improved components? It deviates from what we've done elsewhere with using "Legacy." We might need more discussion on how to talk this presentation on the website, i.e. as a consumer of PatternFly do I know what "React next" means?

mcarrano avatar Aug 19 '22 17:08 mcarrano

I think the examples look good @tlabaj @jeffpuzzo with the assumption that we can continue to add to this.

So is "React next" the labeling we want to apply to these types of new and improved components? It deviates from what we've done elsewhere with using "Legacy." We might need more discussion on how to talk this presentation on the website, i.e. as a consumer of PatternFly do I know what "React next" means?

@mcarrano the tab name can easily be changed if it is determined to not be meaningful enough. We did meet with Sam in terms of naming the import paths for the new components and "next" is what we proposed. That is why we decided to name the tab "React next".

tlabaj avatar Aug 19 '22 17:08 tlabaj

I just noticed that none of the Prop interfaces are listing default values in the docs. Even the props that not defaulted to undefined are blank.

@tlabaj Should be good with the latest changes. Turns out specifying WizardStepProps vs WizardStep (as an example) does not include those defaults.

jpuzz0 avatar Aug 23 '22 19:08 jpuzz0

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Aug 23 '22 20:08 patternfly-build