patternfly-react
patternfly-react copied to clipboard
Build simple ComposableSelect, move current Select examples to Legacy tab
To be determined:
- how many of the current Select examples/variants needs to built into the ComposableSelect?
- will this new page include composable 'demos' to demonstrate how to build out the more complex Select examples?
@nicolethoen @tlabaj I think that we should offer the basic variations that are called out in the design guidelines here: https://www.patternfly.org/v4/components/select/design-guidelines#usage. These include a basic single select, checkbox select (with optional badge/count), typeahead select, and typeahead multi-select. Toggles should be able to be either plain or bordered. Menus can optionally include grouped items, descriptions, and partial loading with a View more footer.
Does this give you enough to work with? If so, I'll get this into a future milestone.
@mcarrano. This is a good starting point. However, I think we should keep the select as simple as possible. I would argue that the view more functionality should not be included and that the consumer build it out. We would still have a demo.
I also think that the typeahead should be built by the consumer. The built in logic for the current select has been problematic in the past. The consumer can currently override the logic it, but in the future I would recommend that we do not build that logic into the component. If the consumer is going to add the logic themselves, I do not see the need to add that the typeahead to the basic select.
@tlabaj I'll defer to your judgment about this. As long as we can build demos of how to create a type-ahead and add view more functionality, I'm OK if these are not included in the simple select examples. So then sounds like that leaves a basic select, checkbox select, and a multi-select that is really just the Options menu. What do you think about examples with an inline filter? Should that be a base example or more like a demo? Or is this redundant with type-ahead?
Per discussion today, let's consider a basic typeahead example without advanced features (e.g. create options, etc). Keep it simple for starters!
#5095 should be addressed in the next version of the select.