patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Core - Add support for React 18

Open jonkoops opened this issue 3 years ago • 10 comments
trafficstars

React 18 has been released, code will have to be adjusted to that it is officially supported.

Checklist

  • [x] https://github.com/patternfly/patternfly-react/issues/6919
  • [x] Update @types/react and @types/react-dom (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56210).
  • [x] #7195
  • [x] #7216
  • [x] #7217
  • [x] #7218
  • [x] #7282
  • [x] #7363
  • [x] #7402
  • [x] Add PropsWithChildren types to components with children
  • [ ] Apply migrations from upgrade guide.
    • [x] #8027
    • [ ] https://github.com/patternfly/patternfly-org/pull/3203
  • [ ] Check for incompatible dependencies and upgrade if necessary.
    • [x] #7706
    • [x] #7826
    • [x] #8577
  • [x] #7303
  • [x] #7821
  • [x] #7827

jonkoops avatar Mar 29 '22 17:03 jonkoops

@jonkoops Thanks for opening this issue. We are in the process of investigating impact of supporting React 18 available in PF. Our initial investigation found that enzyme adapter does not support React 18. Here is the PR #6899 We are currently moving our testing to react-testng-library to remove that dependency. We have several PRs already in the works to do so.
When is your team looking to upgrade?

tlabaj avatar Mar 29 '22 20:03 tlabaj

We're looking to update as soon as possible, but we also have dependencies that are not yet ready for React 18.

I'd like to help out with the upgrade so I've opened up a PR #7146 to do some ground work. It's open to collaborators so everyone can push commits to it. If you'd like we can coordinate our efforts there.

jonkoops avatar Mar 30 '22 10:03 jonkoops

@jonkoops that is great that you would to collaborate. I am going to copy the "to do" list from your PR to the issue for tracking.

tlabaj avatar Apr 05 '22 14:04 tlabaj

Any update on this?

mohd-akram avatar Jun 20 '22 10:06 mohd-akram

@nicolethoen could you re-open this issue? Looks like a closing keyword was used in #7706 so this was closed accidentally.

jonkoops avatar Jul 25 '22 22:07 jonkoops

Is there an ETA for React 18 support?

siwinski avatar Sep 28 '22 14:09 siwinski

React 18 will be supported officially with the next major release of PF, which is tentatively planned to be the first release of 2023.

I believe that this PR: https://github.com/patternfly/patternfly-react/pull/7146 made patternfly React 18 compatible, but I imagine there would still be hiccups fully incorporating it into a React 18 app until we can drop support for React 16 official with that next major release

nicolethoen avatar Sep 28 '22 16:09 nicolethoen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 27 '22 18:11 stale[bot]

Hmmm, I don't think this is stale. There is still some work to be done for proper React 18 support that I haven't gotten to (mostly dependencies).

jonkoops avatar Dec 13 '22 17:12 jonkoops

Thanks @tlabaj!

jonkoops avatar Dec 13 '22 18:12 jonkoops