patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Table - allow providing aria-label to the input for row selection

Open dgdavid opened this issue 8 months ago • 3 comments

Hi there 👋

Just wondering if it would make sense to allow providing a custom aria-label for the input used for row selection (radio or checkbox, depending on the TdSelectType variant). From what I can see, the label is currently hardcoded as Select row ${rowIndex} in the selectable decorator, and I couldn't find a way to customize it.

I'm not sure if I'm missing something or if overriding that label would go against intended usage, but I believe being able to provide a custom value to at least support translations might be useful in some cases.

Would this be a reasonable thing to support?

Thanks!

dgdavid avatar Jul 08 '25 08:07 dgdavid

Hey @dgdavid . Yeah I think that could be helpful - referencing the "primary" data cell in a row might be more helpful to a user ("Select Cluster Zed row" vs "Select row 1" for example), plus for internationalization purposes.

I'll update this issue a bit to triage it properly - if you'd be interested in working on this just let me know

thatblindgeye avatar Jul 24 '25 14:07 thatblindgeye

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Oct 01 '25 11:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Dec 01 '25 11:12 github-actions[bot]