patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

`react-tokens` - include dark theme value in semantic token definitions

Open logonoff opened this issue 8 months ago • 9 comments

Is this a new component or an extension of an existing one? What is the existing component, if any?

@patternfly/react-tokens

Describe the feature A clear and concise description of the new feature. What is the expected behavior?

Semantic token objects in react-tokens should also include the value in dark theme

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths Include screenshots or links to Marvel or other mockups.

Image

Any other information?

logonoff avatar May 02 '25 16:05 logonoff

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 05 '25 11:07 github-actions[bot]

bump

logonoff avatar Jul 05 '25 13:07 logonoff

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 11 '25 11:09 github-actions[bot]

bump

logonoff avatar Sep 11 '25 11:09 logonoff

Moving this into a sprint so it shows up on the board/people are more likely to see the PR.

rebeccaalpert avatar Oct 01 '25 14:10 rebeccaalpert

On versions > v6.3.1 (perhaps earlier) I am noticing that I'm missing tokens for the donut graph. Is this related by chance or should I create a separate issue for that?

Example:

--pf-v6-chart-donut--label--title--Fill is not defined

I'm seeing this for quite a few tokens in Dark mode. This seems quite strange because the documentation, in dark mode, renders just fine.

steverhoades avatar Oct 03 '25 00:10 steverhoades

Example of broken tokens, currently the GraphDonut is broken in Dark Mode. https://www.patternfly.org/charts/donut-chart/-Victory/basic/ https://www.patternfly.org/charts/donut-chart/-Victory/right-aligned-legend/

steverhoades avatar Oct 03 '25 06:10 steverhoades

Popping this out of sprint for now since build is broken.

rebeccaalpert avatar Oct 24 '25 13:10 rebeccaalpert

On versions > v6.3.1 (perhaps earlier) I am noticing that I'm missing tokens for the donut graph. Is this related by chance or should I create a separate issue for that?

@steverhoades, this seems like a separate problem to me. I'd open another issue

logonoff avatar Oct 30 '25 16:10 logonoff