patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Convert examples/demos to TypeScript

Open thatblindgeye opened this issue 1 year ago • 3 comments

Describe the enhancement or change This is a followup epic to https://github.com/patternfly/patternfly-react/issues/6594, which only updated react-core examples/demos. We should finish this initiative off by updating examples in other packages within the react repo, e.g. charts.

Packages to review+update (if a package does not require update, respond in this issue stating so and we can cross it off):

  • [ ] Charts
  • [ ] Code editor
  • [ ] Drag drop
  • [ ] Integration
  • [ ] Table (ignore deprecated directory)
  • [ ] Templates

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

thatblindgeye avatar Feb 28 '25 13:02 thatblindgeye

@thatblindgeye I would like to work on this. Will start with the charts package. It would be great if you can put a list to track the various examples or should I open issues to track each example similar to 6594? Thank You.

Mash707 avatar Mar 12 '25 10:03 Mash707

@Mash707 yes please open a separate issue for each package/batch of updates. The title can just be "[package name] - convert to TypeScript", and just make sure to note in the issue it's related to this epic. I can take care of adding the link to the original comment in a list.

if you can before you start working on anything, try to get an idea of how many files will need to be touched/how big updates will be. We'd prefer having more PRs opened with fewer files/lines touched than a huge PR touching hundreds of files/lines. If you aren't sure feel free to ping me and we can workout whether it would make sense to open multiple PRs or not.

thatblindgeye avatar Mar 26 '25 12:03 thatblindgeye

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar May 28 '25 11:05 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 28 '25 11:07 github-actions[bot]

All other packages meet the standards of using TypeScript and having examples in individual files. Closing as completed, thanks for all the work @Mash707 !

thatblindgeye avatar Aug 04 '25 12:08 thatblindgeye