Bug - [Menu Toggle] - [disabled function not passing down to button]
Describe the problem If the typeahead toggle is disabled, it isn't passing the disabled state down to the button.
Expected behavior The button should also have the disabled state
Screenshots
What is your environment?
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
What is your product and what release date are you targeting?
Any other information?
Thought I left a comment here earlier today, may have closed the tab before I submitted it.
This may involve 2 parts:
- The isDisabled prop on MenuToggle definitely should drill down to the toggle button for a typeahead toggle. Seems like we're not doing that correctly where we're defining the
contentvariable in the component code - Some disabling will fall on the consumer for typeahead toggles, since the MenuToggle doesn't really do anything with whatever is passed to it as
childrenin that case (whether it be a text input or some other button action; in our example code this would be the TextInputGroup and the Button that creates the clear action). We should mention this in documentation (example description) if it isn't already. Without the consumer disabling these things then certain AT can still navigate to the text input and enter text in it, without it being obvious that the text input is meant to be disabled.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.