patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug - [Menu Toggle] - [disabled function not passing down to button]

Open ashley-o0o opened this issue 1 year ago • 3 comments

Describe the problem If the typeahead toggle is disabled, it isn't passing the disabled state down to the button.

Expected behavior The button should also have the disabled state

Screenshots Image

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?

ashley-o0o avatar Jan 27 '25 21:01 ashley-o0o

Thought I left a comment here earlier today, may have closed the tab before I submitted it.

This may involve 2 parts:

  1. The isDisabled prop on MenuToggle definitely should drill down to the toggle button for a typeahead toggle. Seems like we're not doing that correctly where we're defining the content variable in the component code
  2. Some disabling will fall on the consumer for typeahead toggles, since the MenuToggle doesn't really do anything with whatever is passed to it as children in that case (whether it be a text input or some other button action; in our example code this would be the TextInputGroup and the Button that creates the clear action). We should mention this in documentation (example description) if it isn't already. Without the consumer disabling these things then certain AT can still navigate to the text input and enter text in it, without it being obvious that the text input is meant to be disabled.

thatblindgeye avatar Jan 30 '25 18:01 thatblindgeye

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 01 '25 11:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jun 03 '25 11:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Aug 03 '25 11:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Oct 04 '25 11:10 github-actions[bot]