patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Icons - add support for custom icons

Open jenny-s51 opened this issue 1 year ago • 2 comments

Is this a new component or an extension of an existing one? What is the existing component, if any?

Existing, MenuToggle, ToolbarFilter

When using PF tokens to create a custom theme, MenuToggle and ToolbarFilter use default icons in PF that currently cannot be changed via a prop since the prop does not exist, while components like Label, Alert, and Button, offer this functionality.

An alternative option was discussed at today's working session (cc @mcoker), which would include adding support for custom icons directly to react-icons and then importing any custom overrides.

Related: https://github.com/patternfly/patternfly-react/issues/10634

Describe the feature A clear and concise description of the new feature. What is the expected behavior?

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths

See below. MUI uses a different toggle icon for their menu toggle.

Include screenshots or links to Marvel or other mockups. MUI: Screenshot 2024-09-24 at 4 27 39 PM Screenshot 2024-09-25 at 3 21 01 PM

PF: Screenshot 2024-09-24 at 4 28 05 PM Screenshot 2024-09-25 at 3 26 46 PM

Any other information? Would it be possible to prioritize this work for an upcoming sprint to align with RHOAI priorities for the MUI theming effort @nicolethoen ?

jenny-s51 avatar Sep 24 '24 20:09 jenny-s51

Let's set up a meeting to talk about this.

tlabaj avatar Oct 03 '24 15:10 tlabaj

Thank you, @tlabaj . Here’s an update from our sync this morning:

It was clarified by PF that customization support is currently focused on composable components, such as buttons and alerts, to ensure effective usage and mitigate any potential issues with extensive customization. cc @andrew-ronaldson .

Due to current priorities and resource constraints, exploring the extensive scope of this customization effort is not on the roadmap at this time. However, the team is focused on developing a more cohesive icon set for PF components which will drive consistency among PF components which apply these icons.

jenny-s51 avatar Oct 07 '24 16:10 jenny-s51

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Dec 25 '24 11:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 08 '25 11:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 27 '25 11:09 github-actions[bot]