patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

CodeEditor loading property considered by the Editor

Open Ginxo opened this issue 1 year ago • 3 comments

What: Closes #11033

Additional issues:

Ginxo avatar Sep 20 '24 09:09 Ginxo

I would like to see tests for this particular use case not being covered, I will provide as soon as we have an approval about the issue and also the proposal (this PR)

Ginxo avatar Sep 20 '24 09:09 Ginxo

Preview: https://patternfly-react-pr-11034.surge.sh

A11y report: https://patternfly-react-pr-11034-a11y.surge.sh

patternfly-build avatar Sep 20 '24 09:09 patternfly-build

one more additional approver required, please any kind soul aroung? :pray: :wink:

Ginxo avatar Oct 12 '24 10:10 Ginxo

@Ginxo if you need this in v5, can you please change the base branch to the v5 branch

tlabaj avatar Oct 23 '24 14:10 tlabaj

@Ginxo if you need this in v5, can you please change the base branch to the v5 branch

a new PR for V5 already open

Ginxo avatar Oct 24 '24 10:10 Ginxo

@Ginxo We are still in code freeze right now. We will merge your PR once our release is live.

tlabaj avatar Oct 24 '24 17:10 tlabaj