patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

Draft: fix(CodeEditor): Set default height

Open rebeccaalpert opened this issue 1 year ago • 1 comments

The docs state that the default height for CodeEditor is 100%. However, the examples just break if you don't pass in a height. I got it to work with these changes.

What: Closes https://github.com/patternfly/patternfly-react/issues/11013

Additional issues: Waiting on https://github.com/patternfly/patternfly/pull/7087 - I'll pull the style={{}} tags and upgrade once that merges.

rebeccaalpert avatar Sep 17 '24 18:09 rebeccaalpert

Preview: https://patternfly-react-pr-11014.surge.sh

A11y report: https://patternfly-react-pr-11014-a11y.surge.sh

patternfly-build avatar Sep 17 '24 18:09 patternfly-build

This juSt needs core review @mcoker

tlabaj avatar Nov 13 '24 14:11 tlabaj

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Nov 13 '24 18:11 patternfly-build