patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Table sorting needs clarification/revisement

Open thatblindgeye opened this issue 1 year ago • 7 comments

Describe the enhancement or change From the 9/16/2024 design share session, sorting was a topic mentioned, including how "favorites" sorting should work (since typically there's no text to sort by, only an icon).

I gave my initial thoughts on this in the design share, mentioning that if you view it in a sort of alphabetical order, "Favorited" comes before "Unfavorited"/"Not favorited", so following that logic an ascending sort order (with the arrow UP icon) should sort rows so that favorited rows are first (right now our favoritable example does the opposite). Of course this logic kind of breaks depending on the verbiage you're using: "Starred" comes alphabetically after "Not starred". Perhaps if we view it more as an 'active" and "inactive" state universally that logic would fit in all situations, though.

What we should do:

  • Investigate how "favorited" rows should be sorted based on the sort type and what icon should be used; we should see if there's a common pattern for this elsewhere, then from there we may need to update logic in our code.
  • Depending on the outcome of the above, we should make sure we make applicable updates in the core repo as well as update any design guidelines

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

thatblindgeye avatar Sep 16 '24 15:09 thatblindgeye

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jan 21 '25 11:01 github-actions[bot]

cc @andrew-ronaldson @lboehling @kaylachumley do y'all have any thoughts on the sort order of non-text based ("favorited", "checked", etc) columns?

thatblindgeye avatar Feb 28 '25 13:02 thatblindgeye

I like the active/inactive option where the user made a choice to favourtive/star, check, etc. and those should be sorted to the top first. active inactive will work for the alpha sorting too

andrew-ronaldson avatar Feb 28 '25 13:02 andrew-ronaldson

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 30 '25 11:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 02 '25 11:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 08 '25 11:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 12 '25 11:11 github-actions[bot]