patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug - MenuContainer - Should allow distance prop

Open rebeccaalpert opened this issue 1 year ago • 1 comments

Describe the problem Popper allows you to pass in a distance prop, which is the distance between the popper and the trigger. However, MenuContainer does not allow users to pass in a distance prop as a passthrough to Popper. This limits customization of MenuContainer needed for https://github.com/patternfly/virtual-assistant.

How do you reproduce the problem? I have a fork of the component here: https://github.com/patternfly/virtual-assistant/pull/85/files#diff-36e0e80fdd7a3deb91e4ea86c5d9e2c6bb8e7a2db08864a55882b6ea8953b688R26. We just need to add this prop as a pass-through.

Expected behavior I need to pass "distance" from MenuContainer to Popper.

Is this issue blocking you? It's kind of a blocker. I'm forking some PF code in the Virtual Assistant repo for now, but I don't really want to. :)

What is your environment?

  • OS: [e.g. iOS] Mac
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 127.0.6533.120

What is your product and what release date are you targeting? Virtual Assistant extension

rebeccaalpert avatar Aug 22 '24 20:08 rebeccaalpert

I'm pivoting to using Dropdown, so filing a similar issue at https://github.com/patternfly/patternfly-react/issues/10894. I still think it may be useful to expose more of what we allow with Popper, though.

rebeccaalpert avatar Aug 29 '24 13:08 rebeccaalpert