patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Fix issues stemming from publication linting

Open jonkoops opened this issue 1 year ago • 4 comments

This is a tracker issue to fix issues stemming from the publication linter introduced under #10764.

### Issues
- [ ] https://github.com/patternfly/patternfly-react/issues/10831
- [ ] https://github.com/patternfly/patternfly-react/issues/10832
- [ ] Packages do not specify a `files` field
- [ ] Packages do not have valid types
- [ ] Create a codemod to update import paths

jonkoops avatar Aug 03 '24 13:08 jonkoops

Issues #10831 and #10832 relate to this issue.

dlabaj avatar Sep 23 '24 18:09 dlabaj

They are linked as subtasks of this issue :)

jonkoops avatar Sep 24 '24 07:09 jonkoops

After a meeting , the team decided to make changes in non breaking first.

tlabaj avatar Sep 25 '24 19:09 tlabaj

Investigation is still needed to determine whether the change can be made in a non-breaking way. I would advise to test this theory against a complex dependency such as @patternfly/react-core with an existing application in order to validate this.

jonkoops avatar Sep 26 '24 11:09 jonkoops

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jan 06 '25 11:01 github-actions[bot]

@tlabaj can this issue be pinned?

jonkoops avatar Jan 06 '25 14:01 jonkoops

#10832 is a breaking change and will need investigation to determine which exports we should define (some internal helpers are being used currently and we need to decide whether to continue to allow usage).

kmcfaul avatar Jan 27 '25 16:01 kmcfaul

@kmcfaul perhaps it can be done without breaking things, but it would mean exporting everything in the package and then in the next major removing most of the exported API surface in favor of a root export. The amount of export code in the package could be reduced by adding subpath patterns.

jonkoops avatar Jan 27 '25 16:01 jonkoops

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 29 '25 11:03 github-actions[bot]

Could this issue be pinned?

jonkoops avatar Mar 30 '25 10:03 jonkoops

@jonkoops All set.

dlabaj avatar Apr 03 '25 19:04 dlabaj