patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Sankey diagram

Open kuklas opened this issue 1 year ago • 5 comments
trafficstars

New feature, i dont think PF has this

Describe the feature We (Cost management) are looking for Sankey diagram. Competitors are using it in Cost world. Cloudability is using it in the True cost explorer https://technickle.medium.com/thinking-differently-about-sankey-95eae229a82d

PM requested it for the feature, and I believe its useful beyond the feature for everyone that is working with observability. Just not sure about PF and charts, do we create our own or do we use third party?

https://mermaid.js.org/syntax/sankey.html https://issues.redhat.com/browse/COST-5330

kuklas avatar Jul 30 '24 09:07 kuklas

https://nivo.rocks/sankey/

kuklas avatar Jul 30 '24 09:07 kuklas

https://github.com/orgs/patternfly/discussions/5864

kuklas avatar Jul 30 '24 10:07 kuklas

cc @dlabrecq @andrew-ronaldson

tlabaj avatar Jul 30 '24 20:07 tlabaj

Victory does not currently support sankey. However, I recommend using Apache ECharts for this particular chart.

I'll take a look at wrapping this chart with our existing PatternFly themes. Customizing tooltips to look like PatternFly will be a challenge.

dlabrecq avatar Aug 01 '24 13:08 dlabrecq

I recommend NOT using Mermaid JS, which is completely broken. See https://github.com/mermaid-js/mermaid/issues/5684 and linked issues.

SankeyMatic is open source (ISC license) and worked pretty well for me https://sankeymatic.com/ https://github.com/nowthis/sankeymatic

pgarciaq avatar Aug 05 '24 15:08 pgarciaq

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 09 '25 11:03 github-actions[bot]

just received notification about this being stale, I believe Dan is super close to closing this!

kuklas avatar Mar 10 '25 10:03 kuklas

I have a PR waiting to be reviewed https://github.com/patternfly/patternfly-react/pull/11616

dlabrecq avatar Mar 10 '25 14:03 dlabrecq