patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

feat(Button): add text wrapper, update icon usage

Open kmcfaul opened this issue 1 year ago • 1 comments

What: Closes #10626

  • Updates Button such that all children will be wrapped by pf-v6-c-button__text, and whenever an icon is passed in that icon will be wrapped by pf-v6-c-button__icon (was previously for non-plain buttons, now applies to all button icons).
  • Updates usages of our Buttons to passing the icon prop instead of an icon child.
  • Updates DualListSelectorControl to have an icon prop that is passed through to the internal Button.
  • Updates snapshots.

This PR will be failing until https://github.com/patternfly/patternfly-react/pull/10661 is merged due to the core bump.

kmcfaul avatar Jun 26 '24 17:06 kmcfaul

Preview: https://patternfly-react-pr-10663.surge.sh

A11y report: https://patternfly-react-pr-10663-a11y.surge.sh

patternfly-build avatar Jun 26 '24 22:06 patternfly-build

FYI ran visual regression tests before/after this update and there were no differences other than demos that dynamically generate content on page render

Link to the backstop report - backstop-react-7.2.24.pdf

mcoker avatar Jul 02 '24 20:07 mcoker

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Jul 02 '24 21:07 patternfly-build