patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

feat(Page): updated logic to allow section grouping

Open thatblindgeye opened this issue 1 year ago • 1 comments

What: Closes #10622

Codemod issue: https://github.com/patternfly/pf-codemods/issues/674

Additional issues:

thatblindgeye avatar Jun 25 '24 15:06 thatblindgeye

Preview: https://patternfly-react-pr-10650.surge.sh

A11y report: https://patternfly-react-pr-10650-a11y.surge.sh

patternfly-build avatar Jun 25 '24 15:06 patternfly-build

@mcoker

Just curious if we need all 3, and if so, if we could just have one that generates the markup/styles and the other two places could use it (so we're only creating that section markup once)

Updated the first instance. For PageSection with type breadcrumb, do we still intend for a PageSection component to have the breadcrumb class applied? Or should consumers just use the PageBreadcrumb component instead? There are some shared classes being applied to both, PageSection having more that can be applied. Alternatively I suppose we axe PageBreadcrumb and just use PageSection with the type="breadcrumb" passed in.

thatblindgeye avatar Jul 03 '24 18:07 thatblindgeye

or PageSection with type breadcrumb, do we still intend for a PageSection component to have the breadcrumb class applied?

@thatblindgeye yep - as far as I can tell those 3 places added the same class for the breadcrumb section, which we will want to keep. From my perspective, I'd say whatever works better from your perspective re: which to keep - <PageBreadcrumb> or <PageSection type="breadcrumb">. Also don't want to add any overhead to this PR, so if it isn't something we want to tackle now, totally fine, I was mostly just curious why there were 3.

mcoker avatar Jul 03 '24 19:07 mcoker

@mcoker Maybe a post-beta thing to look into regarding the PageBreadcrumb component vs PageSection with breadcrumb variant modifier? Would depend if we want to deprecate PageBreadcrumb/if there'd be any repercussions found when looking into it further.

thatblindgeye avatar Jul 08 '24 12:07 thatblindgeye

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar Jul 15 '24 18:07 patternfly-build