patternfly-react fix(CodeEditor) resizeObserver resize loop

fix(CodeEditor) resizeObserver resize loop

Open Dominik-Petrik opened this issue 1 year ago • 1 comments

trafficstars

What: Closes #10087

Fix is simple enough, but I struggled to reliably reproduce the bug. Please try to reproduce it and validate the fix.

How do you reproduce the problem?

Run react application in webpack with dev error overlay enabled.
Render:

import React from 'react';
import { CodeEditor, Language } from '@patternfly/react-code-editor';
import { editor } from 'monaco-editor/esm/vs/editor/editor.api';

export const ValuesCodeEditor = ({ code }: { code: string }) => {
  const onEditorDidMount = (editor: editor.IStandaloneCodeEditor) => {
    editor.layout();
    editor.focus();
  };

  return (
    <CodeEditor
      isLineNumbersVisible={false}
      isReadOnly
      code={code}
      language={Language.json}
      onEditorDidMount={onEditorDidMount}
      height="400px"
    />
  );
};