patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

Button - update to support wrappers for icon and text

Open mcoker opened this issue 1 year ago • 0 comments

Placeholder issue, follow up to core work in https://github.com/patternfly/patternfly/issues/5944 and https://github.com/patternfly/patternfly/issues/6245

Discussed with @tlabaj the docs/API change could be:

  • Children is always treated as the text. We'll wrap children in the text wrapper.
  • Icons are always passed via the icon prop. Any positioning continues to happen via iconPosition, though we may or may not need to apply a class for the position anymore.
  • ^ applies to all buttons, including plain.

mcoker avatar Jun 17 '24 20:06 mcoker