patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

feat(misc, TextContent): update core version & text content updates

Open kmcfaul opened this issue 1 year ago • 2 comments
trafficstars

What: Closes #10314, #10262, #10335

  • Updated core version to alpha.135
  • Updated generateTokens, removing old, unused files it was pulling in to map vars
  • Updated Text component suite to use default content classes (#10262)
  • Updated Wizard to not use danger token directly & structure update (#10335)
  • Added blurb to docs about Text changes
  • Removed dropdown styles usage from Menu
  • Updated Charts font weight token global_FontWeight_bold to global_font_weight_heading_bold
  • Updated Slider inset token c_slider__step_Left to c_slider__step_InsetInlineStart
  • Updated Td/Th inset tokens c_table__sticky_cell_Left and c_table__sticky_cell_Right to c_table__sticky_cell_InsetInlineStart and c_table__sticky_cell_InsetInlineEnd
  • Updated Toolbar chip group class (variant prop still uses chip-group, but maps to pf-m-label-group now)
  • Updated Wizard Footer to use ActionList (also for deprecated)
  • Updated global height breakpoint token names
  • Updated snapshots
  • Fixed integration tests
  • Updated Table integration demo token global_primary_color_100 to global_color_brand_default
  • Fixed Table transformers test referencing dropdown styles to menu styles
  • Fixed react-token test, updated old token to new token

kmcfaul avatar May 16 '24 17:05 kmcfaul

I'm not sure if it's expected that a bunch of charts colors changed in the snapshots @mcoker Thoughts?

kmcfaul avatar May 16 '24 17:05 kmcfaul

Preview: https://patternfly-react-pr-10378.surge.sh

A11y report: https://patternfly-react-pr-10378-a11y.surge.sh

patternfly-build avatar May 16 '24 17:05 patternfly-build

@tlabaj Noticed that we had one last usage of deprecated SelectOption in a deprecated Table editable cell demo. I updated it to use the new SelectOption, but it looks like that demo doesn't open the select menu. Do we want to open a follow up for this? Or are we planning on eventually removing deprecated Table in v6?

kmcfaul avatar May 20 '24 15:05 kmcfaul

~~@patternfly/design-reviewers @patternfly/core-in-react-reviewers This PR should include the core updates to the Select outlined in https://github.com/patternfly/patternfly-react/issues/10011. If you don't mind using the surge here to re-verify the Select we can get that issue closed here too.~~

Edit: The core PR is actually still up, disregard this note.

kmcfaul avatar May 20 '24 19:05 kmcfaul

@tlabaj Noticed that we had one last usage of deprecated SelectOption in a deprecated Table editable cell demo. I updated it to use the new SelectOption, but it looks like that demo doesn't open the select menu. Do we want to open a follow up for this? Or are we planning on eventually removing deprecated Table in v6?

@kmcfaul Lets open a follow up for this for now.

tlabaj avatar May 21 '24 15:05 tlabaj

Your changes have been released in:

Thanks for your contribution! :tada:

patternfly-build avatar May 21 '24 15:05 patternfly-build