patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Expandable card/Expandable section consistency

Open fhlavac opened this issue 1 year ago • 2 comments
trafficstars

When comparing the Expandable card component to the Expandable section I noticed that the expand toggle icon changes color (black/grey) on focus for the card and not for the expandable section https://www.patternfly.org/components/card#expandable-cards https://www.patternfly.org/components/expandable-section Not sure if that's intentional. It might be worth making the experience consistent.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement? PatternFly React component groups extension - no deadline

fhlavac avatar Feb 15 '24 15:02 fhlavac

cc @mcoker @andrew-ronaldson

tlabaj avatar Feb 26 '24 19:02 tlabaj

In the Card example the icon is the only clickable area but for Expandable sections the Icon + Text block is clickable. This is more obvious in v6 where the icon colours won't change in either component but the card will get the background-color and expandable section won't. For v5 we could sync the icon hover states in both these examples.

Possible v5 update: Card: Icon gray to Black on hover Expandable: Icon gray to black + Link blue default to Link blue hover

andrew-ronaldson avatar Feb 26 '24 20:02 andrew-ronaldson

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 27 '24 11:04 github-actions[bot]

This issue has been closed because it has not had activity since being marked as stale.

github-actions[bot] avatar May 12 '24 11:05 github-actions[bot]