patternfly-react-seed icon indicating copy to clipboard operation
patternfly-react-seed copied to clipboard

Fully built out v6 demo

Open evwilkin opened this issue 1 year ago • 7 comments

Towards #202

This PR adds the following items to the seed app for the V6 demo:

  • Dashboard page
  • Resources page
  • Inventory page
  • Dark/light theme toggle
  • RTL switch
  • Updated favicon

https://pf6-alpha2-demo.surge.sh/

evwilkin avatar Feb 14 '24 00:02 evwilkin

Noticed these issues below: The Events card on the Dashboard screen gets cut off. image

On the same screen this utility classes don't change with dark theme image

Lastly, there is an inline style on the spans. I think this should be using var(--pf-t--global--text--color--subtle) Screenshot 2024-02-22 at 4 16 31 PM

andrew-ronaldson avatar Feb 22 '24 20:02 andrew-ronaldson

@andrew-ronaldson thanks for the feedback, connected with @mcoker (added as reviewer) for suggestions on fixes and fixed the overflowing grid item && update the incorrect text colors (note - now using bold tag rather than another color per suggestion).

evwilkin avatar Mar 22 '24 14:03 evwilkin

Thanks @mcoker, just FYI I went back and made those updates based on your suggestions 👍 @nicolethoen @andrew-ronaldson this demo PR should be in a good place now after feedback & fixes. The one outstanding obvious bug is the chart colors in dark theme, which I believe is yet to be updated for V6 so is as expected.

evwilkin avatar Mar 26 '24 18:03 evwilkin

This just needs to be updated to the latest alphas as soon as the official alpha versions have been announced

nicolethoen avatar Mar 26 '24 20:03 nicolethoen

Screenshot 2024-05-21 at 12 46 35 PM

Thanks for the updates. Seeing this blue bordered section on the page now.

andrew-ronaldson avatar May 21 '24 15:05 andrew-ronaldson

That odd border still appears. Looks like it is from a :visible-focus on main 🤷‍♂️ . Since the labels in the demo are indicating a status we should use p-m-danger/warning/success etc. instead of pf-m-red/green/orange etc. Screenshot 2024-06-27 at 9 12 58 AM

andrew-ronaldson avatar Jun 27 '24 12:06 andrew-ronaldson

Latest surge preview with alpha2 versions: https://pf6-alpha2-demo.surge.sh/

nicolethoen avatar Jun 27 '24 15:06 nicolethoen