patternfly-org icon indicating copy to clipboard operation
patternfly-org copied to clipboard

fix(styling): Allow for spacing between paragraphs of non-stack text

Open wise-king-sullyman opened this issue 1 year ago • 5 comments

Closes #4257

wise-king-sullyman avatar Dec 02 '24 21:12 wise-king-sullyman

Preview: https://patternfly-org-pr-4397-site.surge.sh

patternfly-build avatar Dec 02 '24 21:12 patternfly-build

Looks good! Especially React/HTML pages

Only thing I noticed is that it seems like the spacing above some headings is a little larger (I think mainly h3 and h4's?) For example, here's the current spacing between two headings:

image

vs in this pr:

image

It's more obvious on text-heavy pages (like /about accessibility), but it's still subtle so I don't know if it really matters.

Either way, may be good for a designer's eye to agree with the spacing styling in general --- @andrew-ronaldson could you poke around the preview link and make sure everything feels good?

edonehoo avatar Dec 18 '24 21:12 edonehoo

@wise-king-sullyman Looks like it needs a rebase before the build/synk clears

kmcfaul avatar Apr 02 '25 15:04 kmcfaul

@mcoker were you planning on making any more changes to this after the previous feedback?

wise-king-sullyman avatar May 30 '25 15:05 wise-king-sullyman

@wise-king-sullyman In a perfect world, yes, but I've been busy with other priority work. What are you thinking about handling this issue? Anything in particular you have a question about or would like me to look at?

mcoker avatar May 30 '25 18:05 mcoker