patternfly
docs(icons): Add severity icons to table.
Some notes:
- I can't figure out how to fix the build errors 🥲
- It doesn't look like these icons are in the PF5 Figma kit: is that intentional?
- The "undefined" icon is named "unidentified" in Figma, but I kept undefined in these docs assuming we can update in Figma.
That's an annoying build error - I'm going to need to try to reproduce locally...
@nicolethoen @andrew-ronaldson okay I think pulling in main fixed this
Looks like the critical icon was already in there as something else:
do you see any reason that we can't just remove this one? (just removed it, but can add it back if needed)
I had the same issue in Figma where I was reluctant to remove the old critical icon that teams would be consuming. We could rename it in v5 kit and omit the new icon?
I had the same issue in Figma where I was reluctant to remove the old critical icon that teams would be consuming. We could rename it in v5 kit and omit the new icon?
@andrew-ronaldson had the same concern! Would renaming require code updates to override the old name, though (like if products are importing CriticalRiskIcon)? We could communicate that out if so, but also wondering if that's too disruptive. We could also keep the old icon/old name and rename it with v6 or something?
We could leave it with both icons for the short-term because evewntually the RH icons will replace our existing libraries. That won't disrupt anyone.