patternfly-org icon indicating copy to clipboard operation
patternfly-org copied to clipboard

global vars - remove selector prop, show selector column

Open evwilkin opened this issue 1 year ago • 5 comments

Towards #3551

Note: please leave any suggestions for additional enhancements/changes, I wasn't clear if this was all we need currently.

This PR:

  • Bumps versions to latest alphas
  • Removes the selector prop used in global-css-variables.md that was filtering to only show rules matching selector :where(:root)
    • it now shows all vars, but we could add in new selector :root to only show new vars (or leave as-is showing everything and wait until core cleanup?)
  • Unhides the "selector" column from the global vars table
    • though all the new vars map to the :root selector, this column enables rows to be expanded (where applicable) to track the variable chain.
    • Screenshot 2024-02-12 at 6 47 03 PM

evwilkin avatar Feb 12 '24 23:02 evwilkin

Preview: https://patternfly-org-pr-3886-site.surge.sh

patternfly-build avatar Feb 13 '24 00:02 patternfly-build

This is similar to what I built into the design token docs. I think the biggest difference (other than a few visual differences) is that building it from the design-tokens repo means that they are up to date with the latest in the tokens repo - rather than reading design tokens as passed from design-tokens -> core -> react -> org (which will always be a few steps behind).

nicolethoen avatar Feb 14 '24 15:02 nicolethoen

I was also planning to have the token docs page go in the new 'tokens' subnav item that Erin was building.

nicolethoen avatar Feb 14 '24 16:02 nicolethoen

@nicolethoen that all makes sense and sounds great to me, would you suggest I close this PR out in favor of the momentum you have going in your related issues?

evwilkin avatar Feb 14 '24 16:02 evwilkin

It's possible? Though I hadn't even thought of how the Global CSS vars might be the same or almost the same as the design tokens once all is said and done. It also may be worth a conversation to see what we should do with this page on the v6 site.

nicolethoen avatar Feb 14 '24 18:02 nicolethoen

No longer needed

evwilkin avatar Sep 18 '24 03:09 evwilkin