patternfly-elements
patternfly-elements copied to clipboard
patternfly
fix(core): scroll-spy for non-contiguous regions
See https://github.com/RedHat-UX/red-hat-design-system/pull/2471
What I did
- Simplify the scroll-spy logic, and reconcile scroll-spy active link on scroll
Testing Instructions
- Check out existing jump-links elements
Notes to Reviewers
- There might be serious perf problems with the approach taken here so it should be validated against realworld pages
🦋 Changeset detected
Latest commit: 616bd7554300e540515ecbd04f6e98d8e3b9845f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @patternfly/pfe-core | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for patternfly-elements ready!
| Name | Link |
|---|---|
| Latest commit | e0469328212eb4a1e84bbc3bd59ba4cae0292a81 |
| Deploy Preview | https://deploy-preview-2920--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
✅ Commitlint tests passed!
More Info
{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(core): scroll-spy for non-contiguous regions"
}
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}