patternfly-elements
patternfly-elements copied to clipboard
patternfly
fix(tooltip): make content inert when hidden
What I did
- make tooltip content inert when hidden. Fixes #2902
Testing Instructions
- view repro instructions in linked issue
Notes to Reviewers
- Pay attention to a11y / SR use
🦋 Changeset detected
Latest commit: 63375c15a3e2d35f14ba6770168fff1f3fd9aa25
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @patternfly/elements | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
✅ Commitlint tests passed!
More Info
{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tooltip): make content inert when hidden"
}
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
✅ Commitlint tests passed!
More Info
{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tooltip): make content inert when hidden"
}
Deploy Preview for patternfly-elements ready!
| Name | Link |
|---|---|
| Latest commit | e1a9f6399a0c72fd9fe9d2a59628c9f0c87253b1 |
| Deploy Preview | https://deploy-preview-2908--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for patternfly-elements ready!
| Name | Link |
|---|---|
| Latest commit | 63375c15a3e2d35f14ba6770168fff1f3fd9aa25 |
| Latest deploy log | https://app.netlify.com/projects/patternfly-elements/deploys/68851a0170061b000846f660 |
| Deploy Preview | https://deploy-preview-2908--patternfly-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
I have requested more detailed instructions from Tejas about what words/characters to specifically hightlight and copy/paste.
In my initial review, it appears this PR doesn't solve Tejas's issue. Results appear to be identical in this PR's DP and on pfe.org.
Interestingly, you get different clipboard results when copy/pasting into a text document versus Google Docs. Not sure if this is a PFE or Google Docs thing. 🤷♂️
