patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

fix(jump-links): landmark label

Open bennypowers opened this issue 1 year ago • 6 comments

Closes #2860

What I did

  1. add aria-labelledby="label" to the nav landmark element

Testing Instructions

  1. confirm that screen readers read the page correctly

Notes to Reviewers

  1. Note that the listbox is already labelled by the same element.

bennypowers avatar Oct 27 '24 06:10 bennypowers

🦋 Changeset detected

Latest commit: a8397ef3f1a85b9a2e5b70db9e3564f14f84fb92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 27 '24 06:10 changeset-bot[bot]

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(jump-links): landmark label"
}

github-actions[bot] avatar Oct 27 '24 06:10 github-actions[bot]

Deploy Preview for patternfly-elements ready!

Name Link
Latest commit 3a5d314ea48dbd57381a61a30959720ab605d1a4
Deploy Preview https://deploy-preview-2870--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 27 '24 06:10 netlify[bot]

SSR Test Run for af81208a98631a198b0314a6eb865b7be76a4dd2: Report

github-actions[bot] avatar Oct 27 '24 06:10 github-actions[bot]

SSR Test Run for 9c8154f6b798625631b74ab64127f0facc48f257: Report

github-actions[bot] avatar Nov 05 '24 11:11 github-actions[bot]

SSR Test Run for 3a5d314ea48dbd57381a61a30959720ab605d1a4: Report

github-actions[bot] avatar Nov 05 '24 17:11 github-actions[bot]