patternfly
fix(label)!: remove BaseLabel
Closes #2620
What I did
- remove baselabel
Testing Instructions
- compare dp to prod demos
Notes to Reviewers
- see https://github.com/RedHat-UX/red-hat-design-system/pull/1279
- this pr causes label to remove itself on close if the event isn't cancelled. is that desired?
- don't merge until non-breaking changes are released in 2.5.0
🦋 Changeset detected
Latest commit: c7d0ee8fc0b8feb4bbdcb6de36b074090670aded
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @patternfly/elements | Major |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for patternfly-elements ready!
| Name | Link |
|---|---|
| Latest commit | f24d30dc05f14b1eebd88a2069a3cecc3f8ea398 |
| Deploy Preview | https://deploy-preview-2632--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
2. this pr causes label to remove itself on close if the event isn't cancelled. is that desired?
I take it you are making reference to whether or not the close button should do anything internally?
Patternfly does not provide remove functionality directly and needs wired up, removal of the element .remove() is most likely preferred as it is already triggering the LabelCloseEvent that implementation can use to do whatever it is they desire on the click.
- this pr causes label to remove itself on close if the event isn't cancelled. is that desired?
I take it you are making reference to whether or not the close button should do anything internally?
Patternfly does not provide remove functionality directly and needs wired up, removal of the element
.remove()is most likely preferred as it is already triggering theLabelCloseEventthat implementation can use to do whatever it is they desire on the click.
And I now see the change in the changeset that instead provides an example of how to cancel the event, reverted commit to change that behavior. My bad.